Add "people create"

piket_client/cli.py

@@ -70,6 +70,20 @@ def list_people(active: bool) -> None:
     print(table)
 
 
+@people.command("create")
+@click.option("--display-name", type=click.STRING)
+@click.argument("name", type=click.STRING)
+def create_person(name: str, display_name: str) -> None:
+    """Create a person."""
+    person = Person(full_name=name, display_name=display_name).create()
+
+    if isinstance(person, NetworkError):
+        print_error(f"Could not create Person: {person.value}")
+        return
+
+    print_ok(f'Created person "{name}" with ID {person.person_id}.')
+
+
 @cli.group()
 def settlements():
     pass

piket_client/model.py

@@ -130,29 +130,36 @@ class Person(NamedTuple):
             )
             return None
 
-    def create(self) -> Optional[Person]:
+    def create(self) -> Union[Person, NetworkError]:
         """ Create a new Person from the current attributes. As tuples are
         immutable, a new Person with the correct id is returned. """
-        req = requests.post(
-            urljoin(SERVER_URL, "people"),
-            json={"person": {"name": self.name, "active": True}},
-        )
 
         try:
-            data = req.json()
-        except ValueError:
-            LOG.error(
-                "Did not get JSON on adding Person (%s): %s",
-                req.status_code,
-                req.content,
+            req = requests.post(
+                urljoin(SERVER_URL, "people"),
+                json={
+                    "person": {
+                        "full_name": self.full_name,
+                        "display_name": self.display_name,
+                        "active": True,
+                    }
+                },
             )
-            return None
+            req.raise_for_status()
+            data = req.json()
+            return Person.from_dict(data["person"])
 
-        if "error" in data or req.status_code != 201:
-            LOG.error("Could not create Person (%s): %s", req.status_code, data)
-            return None
+        except requests.ConnectionError as e:
+            LOG.exception(e)
+            return NetworkError.ConnectionFailure
 
-        return Person.from_dict(data["person"])
+        except requests.HTTPError as e:
+            LOG.exception(e)
+            return NetworkError.HttpFailure
+
+        except ValueError as e:
+            LOG.exception(e)
+            return NetworkError.InvalidData
 
     def set_active(self, new_state=True) -> Optional[Person]:
         req = requests.patch(

piket_server/routes/people.py

@@ -43,7 +43,11 @@ def add_person():
         return jsonify({"error": "Could not parse JSON."}), 400
 
     data = json.get("person") or {}
-    person = Person(name=data.get("name"), active=data.get("active", False))
+    person = Person(
+        full_name=data.get("full_name"),
+        active=data.get("active", False),
+        display_name=data.get("display_name", None),
+    )
 
     try:
         db.session.add(person)