fixup! server: Add Aardbei fields to Person

piket_server/__init__.py

@@ -37,7 +37,7 @@ class Person(db.Model):
     consumptions = db.relationship("Consumption", backref="person", lazy=True)
 
     def __repr__(self) -> str:
-        return f"<Person {self.person_id}: {self.name}>"
+        return f"<Person {self.person_id}: {self.full_name}>"
 
     @property
     def as_dict(self) -> dict:
@@ -144,11 +144,11 @@ class Settlement(db.Model):
                 .filter_by(reversed=False)
                 .filter_by(consumption_type=c_type)
                 .group_by(Consumption.person_id)
-                .order_by(Person.name)
+                .order_by(Person.full_name)
                 .outerjoin(Person)
                 .with_entities(
                     Person.person_id,
-                    Person.name,
+                    Person.full_name,
                     func.count(Consumption.consumption_id),
                 )
                 .all()
@@ -205,7 +205,7 @@ class Consumption(db.Model):
     reversed = db.Column(db.Boolean, default=False, nullable=False)
 
     def __repr__(self) -> str:
-        return f"<Consumption: {self.consumption_type.name} for {self.person.name}>"
+        return f"<Consumption: {self.consumption_type.name} for {self.person.full_name}>"
 
     @property
     def as_dict(self) -> dict:
@@ -256,8 +256,8 @@ def status() -> None:
 @app.route("/people", methods=["GET"])
 def get_people():
     """ Return a list of currently known people. """
-    people = Person.query.order_by(Person.name).all()
-    q = Person.query.order_by(Person.name)
+    people = Person.query.order_by(Person.full_name).all()
+    q = Person.query.order_by(Person.full_name)
     if request.args.get("active"):
         active_status = request.args.get("active", type=int)
         q = q.filter_by(active=active_status)

piket_server/alembic/versions/cca57457a0a6_add_aardbei_fields.py

@@ -18,13 +18,13 @@ depends_on = None
 
 def upgrade():
     with op.batch_alter_table("people") as batch_op:
-        batch_op.alter_column("name", new_name="full_name")
+        batch_op.alter_column("name", new_column_name="full_name")
         batch_op.add_column(sa.Column("aardbei_id", sa.Integer(), nullable=True))
         batch_op.add_column(sa.Column("display_name", sa.String(), nullable=True))
 
 
 def downgrade():
     with op.batch_alter_table("people") as batch_op:
-        batch_op.alter_column("full_name", new_name="name")
+        batch_op.alter_column("full_name", new_column_name="name")
         batch_op.drop_column("aardbei_id")
         batch_op.drop_column("display_name")