Add renaming to piket-cli

piket_client/cli.py

@@ -1,4 +1,8 @@
+from typing import Optional
+
 import click
+from prettytable import PrettyTable
+
 from piket_client.model import (
     AardbeiActivity,
     ServerStatus,
@@ -9,7 +13,6 @@ from piket_client.model import (
     Settlement,
     ConsumptionType,
 )
-from prettytable import PrettyTable
 
 
 @click.group()
@@ -86,6 +89,27 @@ def create_person(name: str, display_name: str) -> None:
     print_ok(f'Created person "{name}" with ID {person.person_id}.')
 
 
+@people.command("rename")
+@click.argument("person-id", type=click.INT)
+@click.option("--new-full-name", type=click.STRING)
+@click.option("--new-display-name", type=click.STRING)
+def rename_person(
+    person_id: int, new_full_name: Optional[str], new_display_name: Optional[str],
+) -> None:
+
+    person = Person.get(person_id)
+
+    if person is None:
+        raise click.UsageError(f"Cannot find Person {person_id}!")
+
+    if new_full_name is None and new_display_name is None:
+        raise click.UsageError("No new full name or display name specified!")
+
+    new_person = person.rename(
+        new_full_name=new_full_name, new_display_name=new_display_name
+    )
+
+
 @cli.group()
 def settlements():
     pass

piket_client/model.py

@@ -161,6 +161,38 @@ class Person(NamedTuple):
             LOG.exception(e)
             return NetworkError.InvalidData
 
+    def rename(
+        self, new_full_name: Optional[str], new_display_name: Optional[str]
+    ) -> Optional[Person]:
+        person_payload: Dict[str, str] = {}
+
+        if new_full_name is not None:
+            person_payload["full_name"] = new_full_name
+
+        if new_display_name is not None:
+            person_payload["display_name"] = new_display_name
+
+        req = requests.patch(
+            urljoin(SERVER_URL, f"people/{self.person_id}"),
+            json={"person": person_payload},
+        )
+
+        try:
+            data = req.json()
+        except ValueError:
+            LOG.error(
+                "Did not get JSON on updating Person (%s): %s",
+                req.status_code,
+                req.content,
+            )
+            return None
+
+        if "error" in data or req.status_code != 200:
+            LOG.error("Could not update Person (%s): %s", req.status_code, data)
+            return None
+
+        return Person.from_dict(data["person"])
+
     def set_active(self, new_state=True) -> Optional[Person]:
         req = requests.patch(
             urljoin(SERVER_URL, f"people/{self.person_id}"),
@@ -622,7 +654,9 @@ class AardbeiPeopleDiff:
         return cls(**data)
 
     @classmethod
-    def get_diff(cls, token: str, endpoint: str) -> Union[AardbeiPeopleDiff, NetworkError]:
+    def get_diff(
+        cls, token: str, endpoint: str
+    ) -> Union[AardbeiPeopleDiff, NetworkError]:
         try:
             req = requests.post(
                 urljoin(SERVER_URL, "/aardbei/diff_people"),

piket_server/routes/people.py

@@ -63,14 +63,25 @@ def update_person(person_id: int):
     person = Person.query.get_or_404(person_id)
 
     data = request.json["person"]
+    changed = False
 
     if "active" in data:
         person.active = data["active"]
+        changed = True
 
+    if "full_name" in data:
+        person.full_name = data["full_name"]
+        changed = True
+
+    if "display_name" in data:
+        person.display_name = data["display_name"]
+        changed = True
+
+    if changed:
         db.session.add(person)
         db.session.commit()
 
-        return jsonify(person=person.as_dict)
+    return jsonify(person=person.as_dict)
 
 
 @app.route("/people/<int:person_id>/add_consumption", methods=["POST"])