Explorar el Código

Safe navigation

Maarten van den Berg %!s(int64=6) %!d(string=hace) años
padre
commit
a64bbed723
Se han modificado 2 ficheros con 1 adiciones y 8 borrados
  1. 0 7
      .rubocop.yml
  2. 1 1
      app/controllers/api_controller.rb

+ 0 - 7
.rubocop.yml

10
   Exclude:
10
   Exclude:
11
     - 'db/schema.rb'
11
     - 'db/schema.rb'
12
 
12
 
13
-# Offense count: 1
14
-# Configuration parameters: Whitelist.
15
-# Whitelist: present?, blank?, presence, try, try!
16
-Lint/SafeNavigationChain:
17
-  Exclude:
18
-    - 'app/controllers/api_controller.rb'
19
-
20
 # Offense count: 30
13
 # Offense count: 30
21
 Metrics/AbcSize:
14
 Metrics/AbcSize:
22
   Max: 71
15
   Max: 71

+ 1 - 1
app/controllers/api_controller.rb

36
 
36
 
37
   # Require user to be a member of group OR admin, requires @group set
37
   # Require user to be a member of group OR admin, requires @group set
38
   def require_membership!
38
   def require_membership!
39
-    return if current_person&.groups.include?(@group) || current_person&.is_admin?
39
+    return if current_person&.groups&.include?(@group) || current_person&.is_admin?
40
 
40
 
41
     @message = I18n.t('authentication.membership_required')
41
     @message = I18n.t('authentication.membership_required')
42
     render 'api/error', status: :forbidden
42
     render 'api/error', status: :forbidden